fix: restore choice tags on state reloading #1023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Choice tags were missing in serialisation and deserialisation of state to/from JSON. Fixes y-lohse#1022
|
Linter and test passed on the pipeline 🥳 |
|
Tentatively pinging @joethephish on this one, as the save format should be future-compatible with the C# runtime. |
|
Yep think this makes sense! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Choice tags were missing in serialisation and deserialisation of state to/from JSON.
Fixes #1022
Checklist
npm test).npm run test:typescript) but runningnpm run test:javascriptproduces many (unrelated?) failures.npm run-script lint).npm run-script lint:fixtouches a few files, it doesn't add any changes.Description
See above.